[Skiboot] [PATCH] IPMI: Fix eSEL logging issue

Ananth N Mavinakayanahalli ananth at in.ibm.com
Sun Aug 2 17:42:59 AEST 2015


On Fri, Jul 31, 2015 at 11:56:03PM +0530, Vasant Hegde wrote:
> Presently we are passing PEL log without adding eSEL structure
> information. Hence logging eSEL information is failing.
> 
> This patch send Extend SEL structure information before sending
> actual PEL log... so that BMC understands its eSEL log and logs
> it apropriately.
> 
> Signed-off-by: Vasant Hegde <hegdevasant at linux.vnet.ibm.com>
> Cc: Alistair Popple <alistair at popple.id.au>
> Cc: Jeremy Kerr <jk at ozlabs.org>
> ---
>  hw/ipmi/ipmi-sel.c | 61 ++++++++++++++++++++++++++++++++++++++++++++----------
>  1 file changed, 50 insertions(+), 11 deletions(-)
> 
> diff --git a/hw/ipmi/ipmi-sel.c b/hw/ipmi/ipmi-sel.c
> index 05ac977..cce4042 100644
> --- a/hw/ipmi/ipmi-sel.c
> +++ b/hw/ipmi/ipmi-sel.c
> @@ -56,6 +56,30 @@ struct oem_sel {
>  	uint8_t data[4];
>  };
>  
> +/* Extend SEL OEM Record Entry */
> +struct oem_esel {
> +	uint16_t	record_id;

leint16_t?

> +	uint8_t		record_type;
> +	uint32_t	timestamp;
> +	uint16_t	generator_id;
> +	uint8_t		evm_ver;
> +	uint8_t		sensor_type;
> +	uint8_t		sensor_number;
> +	uint8_t		event_dir_type;
> +	uint8_t		signature;
> +	uint16_t	offset;

This too?

> +} __packed;

Haven't looked at the rest of the patch yet. We also need to add logic
for fetching eSELs split over multiple packets.

Ananth



More information about the Skiboot mailing list