[Skiboot] [PATCH] Adjust skiboot_cpu_stacks region size according to real max PIR
stewart at linux.vnet.ibm.com
Thu Apr 30 11:48:46 AEST 2015
Benjamin Herrenschmidt <benh at kernel.crashing.org> writes:
> Cosmetic comments only:
>> diff --git a/core/init.c b/core/init.c
>> index 445272a..0e91a9d 100644
>> --- a/core/init.c
>> +++ b/core/init.c
>> @@ -634,6 +634,8 @@ void __noreturn main_cpu_entry(const void *fdt, u32 master_cpu)
>> /* Initialize the rest of the cpu thread structs */
>> + /* We now know real max PIR, so adjust mem region appropriately */
>> + adjust_cpu_stacks_len_to_max_pir();
> I like having a blank line between comment+function :-)
So do I usually... I fail at enter key usage.
> Also I tend to dislike enormous_function_names_from_hell().
So do I... I was just trying to be as descriptive as possible so that I
didn't need to comment it... and I left the comment in.
> What about adjust_cpu_stacks_alloc() ?
More information about the Skiboot