[Skiboot] [PATCH 5/6] FSP/ELOG: Reduce elog write buffer size

Vasant Hegde hegdevasant at linux.vnet.ibm.com
Tue Apr 7 22:57:06 AEST 2015

Present we are allocating 64K for emergency and host buffer. But
we just need 16K (which is the max elog size). Hence reduce the
variable size to 16K.

Similarly we are allocating 256K for normal fsp write error log path.
(elog_write_to_fsp_buffer). But in reality we just need 16K. Hence
reduce this size as well.

Note that we have top level elog pool with 64 entries of 16K to hold
multiple errors. So we are fine here.

Signed-off-by: Vasant Hegde <hegdevasant at linux.vnet.ibm.com>
 hw/fsp/fsp-elog-write.c |    6 +++---
 1 file changed, 3 insertions(+), 3 deletions(-)

diff --git a/hw/fsp/fsp-elog-write.c b/hw/fsp/fsp-elog-write.c
index e547cc0..58dff20 100644
--- a/hw/fsp/fsp-elog-write.c
+++ b/hw/fsp/fsp-elog-write.c
@@ -44,13 +44,13 @@ static struct lock elog_panic_write_lock = LOCK_UNLOCKED;
 static struct lock elog_write_to_host_lock = LOCK_UNLOCKED;
 /* log buffer  to copy FSP log for READ */
-#define ELOG_WRITE_TO_FSP_BUFFER_SIZE	0x00040000
+#define ELOG_WRITE_TO_FSP_BUFFER_SIZE	0x00004000
 static void *elog_write_to_fsp_buffer;
+#define ELOG_PANIC_WRITE_BUFFER_SIZE	0x00004000
 static void *elog_panic_write_buffer;
+#define ELOG_WRITE_TO_HOST_BUFFER_SIZE	0x00004000
 static void *elog_write_to_host_buffer;
 static uint32_t elog_write_retries;

More information about the Skiboot mailing list