[Skiboot] [PATCH v2 00/12] FSP/LED: Add SAI and LED mode support

Vasant Hegde hegdevasant at linux.vnet.ibm.com
Mon Apr 6 18:28:36 AEST 2015

This patchset adds System Attention Indicator (SAI) and LED mode support
in OPAL.

LED mode:
  FSP based system can work on two LED modes:
   Light Path   : Both identify and fault LEDs are supported
   Guiding Light: Only identify LEDs are supported

  FSP sends LED mode information via HDAT. We use this information during
  LED device tree node creation. We only expose relevent LEDs to host.

System Attention Indicator:
  Unlike other indicators, this indicator is controlled by FSP. FSP sends
  this indicator details to OPAL via HDAT. We parse HDAT to get location

  During LED init get use MBOX command to get LED state. Later anytime
  FSP updates this LED we get system parameter update notification. We
  use that to update cached data. Lastly we use MBOX command to send
  LED update request to FSP.

System parameter update notifier:
  Last 2 patches adds new System parameter update notifier. So interested
  clients (like LED) can register to these notifier and get update

 On 830 FW, SLCA (part of HDAT) is not giving right SAI location code. I
 have requested FSP folks to look into this issue. On 810 FW, it working

  - Add get LED state response to SAI.
    This requires minor change in our code. Waiting for clarification from FSP.
    Once I get clarification, I will send separate patch to fix this.


Vasant Hegde (12):
      FSP/LED: Move led header file to include directory
      FSP/LED: Define macro instead of hardcoding led type
      OPAL: Validate before creating opal device tree node
      FSP/LED: Validate before creating led node
      hdata: Create LED node
      hdata: Detect LED mode and populate device tree
      FSP/LED: Use LED mode information
      FSP/hdata: Populate System Attention Indicator location code
      FSP/LED: Get SAI location code from device tree
      FSP/LED: Add system attention indicator support
      FSP/SYSPARAM: Introduce update notify system parameter notifier
      FSP/LED: Handle SA indicator update notification

 core/opal.c                               |    6 -
 doc/device-tree/ibm,opal/led.txt          |    3 
 doc/opal-api/opal-led-get-set-114-115.txt |   19 ++
 hdata/hdata.h                             |    1 
 hdata/slca.c                              |   79 ++++++++
 hdata/spira.c                             |   35 +++
 hdata/spira.h                             |    2 
 hw/fsp/fsp-leds.c                         |  299 ++++++++++++++++++++++++++++-
 hw/fsp/fsp-leds.h                         |  153 ---------------
 hw/fsp/fsp-sysparam.c                     |   49 +++++
 include/fsp-leds.h                        |  179 +++++++++++++++++
 include/fsp-sysparam.h                    |   15 +
 include/fsp.h                             |   12 +
 include/opal-api.h                        |    3 
 14 files changed, 685 insertions(+), 170 deletions(-)
 delete mode 100644 hw/fsp/fsp-leds.h
 create mode 100644 include/fsp-leds.h


More information about the Skiboot mailing list