[Skiboot] [RFC PATCH 2/2] libflash/file: add file abstraction for libflash

[Cyril Bur]

On Thu, 2015-03-26 at 14:09 +1100, Daniel Axtens wrote:
> Hi Cyril,
> 
> There are some really minor comments below. Once they're addressed, I'm
> happy to give it a Reviewed-by.
> 
> 
> > diff --git a/libflash/file_flash.c b/libflash/file_flash.c
> > new file mode 100644
> > index 0000000..d902672
> > --- /dev/null
> > +++ b/libflash/file_flash.c
> > @@ -0,0 +1,224 @@
> This probably needs some boilerplate with copyright?
> 
Stewart said he has dealt with this :)
> 
> > +
> > +/* The caller is going to have to supply this */
> The what is what now? I think you're trying to say that on setup
> (build_flash_ctrl), a file descriptor has to be provided. (Which, as I
> understand it, is pretty much implied by the build_flash_ctrl prototype
> anyway.)

Comment is a bit out of place in the final version yep, left over from
moving code around and trying out ideas, removed.

> > +struct file_flash_priv {
> > +	int fd;
> > +};+
> 
> 
> 
> > diff --git a/libflash/file_flash.h b/libflash/file_flash.h
> This will probably also need copyright boilerplate.
> 
> > new file mode 100644
> > index 0000000..dc6b5d7
> > --- /dev/null
> > +++ b/libflash/file_flash.h
>