[Skiboot] [PATCH] FSP: Reset the response outstanding bitmap on reset start

Ananth N Mavinakayanahalli ananth at in.ibm.com
Wed Dec 10 15:37:29 AEDT 2014


Once we have the FSP in reset, we don't expect it to respond to any
outstanding mbox commands for which we are expecting one. Reset the
bitmap to reflect the same.

Signed-off-by: Ananth N Mavinakayanahalli <ananth at in.ibm.com>
---
 hw/fsp/fsp.c |    6 ++++++
 1 file changed, 6 insertions(+)

diff --git a/hw/fsp/fsp.c b/hw/fsp/fsp.c
index 1bc236c..507619a 100644
--- a/hw/fsp/fsp.c
+++ b/hw/fsp/fsp.c
@@ -349,6 +349,12 @@ static void fsp_reset_cmdclass(void)
 	int i;
 	struct fsp_msg *msg;
 
+	/*
+	 * The FSP is in reset and hence we can't expect any response
+	 * to outstanding messages that we've already sent. Clear the
+	 * bitmap to reflect that.
+	 */
+	fsp_cmdclass_resp_bitmask = 0;
 	for (i = 0; i <= (FSP_MCLASS_LAST - FSP_MCLASS_FIRST); i++) {
 		struct fsp_cmdclass *cmdclass = &fsp_cmdclass[i];
 		cmdclass->busy = false;



More information about the Skiboot mailing list