[Skiboot] [PATCH] ipmi/fru: Remove redundant version information

Stewart Smith stewart at linux.vnet.ibm.com
Wed Dec 3 17:41:09 AEDT 2014

alistair at popple.id.au writes:
> From: Alistair Popple <alistair at popple.id.au>
> The FRU data format limits string length to 31 characters. Currently
> we truncate the version string as required but leave the redundant
> (because it's included in the product name field) "skiboot-" at the
> start of the version.
> This patch removes the redundant prefix allowing more of the actual
> version string to be stored. It also fixes a bug which caused the last
> character of a 31 character version string to be overwritten as well
> as a rather embarrassing off-by-one buffer overflow.
> Note that 31 characters should be enough to store the complete version
> string for any release builds.

thanks, merged!

More information about the Skiboot mailing list