[Skiboot] [PATCH] ipmi/fru: Add support for populating fru data

Alistair Popple alistair at popple.id.au
Wed Dec 3 10:23:41 AEDT 2014


Hi Stewart,

On Tue, 2 Dec 2014 17:47:19 Stewart Smith wrote:
> Looks good (and merged). One thing to keep in mind is that the version
> string we generate can get pretty long (i've clocked 53 characters
> once).. maybe we want to truncate the leading 'skiboot-' ?

We already truncate the version string (adding a + at the end if it's too 
long) however removing the leading skiboot- is a good idea. I will get a patch 
together to do that. In released versions the idea was we shouldn't have to 
truncate the version as a released skiboot shouldn't have the alistair-dirty-
blah-blah-blah at the end anyway.

Regards,

Alistair



More information about the Skiboot mailing list