[Skiboot-stable] [PATCH v2] platform/mihawk: Fix IPMI double-free

Nichole Wang Nichole_Wang at wistron.com
Tue Jun 16 11:23:24 AEST 2020


From: nichole <Nichole_Wang at wistron.com>

The commit 6826095 ("platform/mihawk: support dynamic PCIe slot table")
added the IPMI OEM command to communicate with BMC. We do the
ipmi_free_msg(msg) twice that caused the Fast-reboot fail.

This patch fixes it by removing the IPMI double-free bug to restore
Fast-reboot.

Signed-off-by: Nichole Wang <Nichole_Wang at wistron.com>
Cc: skiboot-stable at lists.ozlabs.org # skiboot-6.6.x
Cc: skiboot-stable at lists.ozlabs.org # skiboot-op940.x
Fixes: commit 6826095 ("platform/mihawk: support dynamic PCIe slot table")
---
 platforms/astbmc/mihawk.c | 2 --
 1 file changed, 2 deletions(-)

diff --git a/platforms/astbmc/mihawk.c b/platforms/astbmc/mihawk.c
index f3669ff..54c2884 100644
--- a/platforms/astbmc/mihawk.c
+++ b/platforms/astbmc/mihawk.c
@@ -533,8 +533,6 @@ static void mihawk_init(void)
 			if (timeout_ms == 0)
 				break;
 		}
-
-		ipmi_free_msg(ipmi_msg);
 	}
 
 	prlog(PR_DEBUG, "Mihawk: IPMI_RISERF_QUERY finish. riser_state: %02x"
-- 
2.7.4


---------------------------------------------------------------------------------------------------------------------------------------------------------------
This email contains confidential or legally privileged information and is for the sole use of its intended recipient. 
Any unauthorized review, use, copying or distribution of this email or the content of this email is strictly prohibited.
If you are not the intended recipient, you may reply to the sender and should delete this e-mail immediately.
---------------------------------------------------------------------------------------------------------------------------------------------------------------


More information about the Skiboot-stable mailing list