From oohall at gmail.com Fri Nov 8 16:07:37 2019 From: oohall at gmail.com (Oliver O'Halloran) Date: Fri, 8 Nov 2019 16:07:37 +1100 Subject: [Skiboot-stable] [Skiboot] [PATCH] npu2-opencapi: Fix integer promotion bug in LPC allocation In-Reply-To: <20190926125545.21745-1-ajd@linux.ibm.com> References: <20190926125545.21745-1-ajd@linux.ibm.com> Message-ID: On Thu, Sep 26, 2019 at 10:57 PM Andrew Donnellan wrote: > > If you try to allocate an amount of LPC memory that's not a power of 2, > we round the value up to the nearest power of 2. > > By the magic of C, "1 << n" gets treated as an int, even if you're > assigning it to a uint64_t. > > Change 1 to 1ULL to fix this. > > (C, it's great.) > > Reported-by: Alastair D'Silva > Cc: skiboot-stable at lists.ozlabs.org > Signed-off-by: Andrew Donnellan Merged as of e85e2e2b8b0a4dd96e10343df19df1a161cd6aac From klaus at linux.vnet.ibm.com Mon Nov 25 23:52:31 2019 From: klaus at linux.vnet.ibm.com (Klaus Heinrich Kiwi) Date: Mon, 25 Nov 2019 09:52:31 -0300 Subject: [Skiboot-stable] Enforcing 2FA on our github repositories In-Reply-To: <9b3f6fb7-b8c6-14d1-74da-93923090ec72@linux.vnet.ibm.com> References: <9b3f6fb7-b8c6-14d1-74da-93923090ec72@linux.vnet.ibm.com> Message-ID: Reminder that 2FA will be enforced for all repositories of github.com/open-power and github.com/ibm-op-release starting today... You will be excluded for these organizations and have your private forks from those repositories removed if you don't already have 2FA enabled for your Github profile. However, it is possible to re-instate those if you enable 2FA for your repositories in the next 3 months, and send me an e-mail to re-instate your membership. ?-Klaus On 10/24/2019 3:44 AM, Klaus Heinrich Kiwi wrote: > Dear Openpower-Firmware community members, > starting November 25th, 2019, the github.com/open-power and > github.com/ibm-op-release organizations will start enforcing > two-factor authentication (2FA) for interacting with it's > repositories, meaning that "members, outside collaborators, and > billing managers (including bot accounts) who do not use 2FA will be > removed from the organization and lose access to its repositories"[1] > In order to not be removed, before Nov 25 2019, please enable 2FA[2] > for all your Github.com accounts interacting with any of the several > repositories contained within these organizations. These include, but > are not limited to: skiboot, petitboot, op-test, op-build, hostboot, > sbe, occ, platform XML files, etc > This action is aimed at better protecting the repositories and our > members, i.e., avoiding account hijacking and rogue code insertion. > Thank you for your support, > ?-Klaus > [1] - > https://help.github.com/en/articles/requiring-two-factor-authentication-in-your-organization > [2] - > https://help.github.com/en/articles/securing-your-account-with-two-factor-authentication-2fa > Klaus Heinrich Kiwi > OPAL Project Lead > -- Klaus Heinrich Kiwi From hegdevasant at linux.vnet.ibm.com Tue Nov 26 02:19:14 2019 From: hegdevasant at linux.vnet.ibm.com (Vasant Hegde) Date: Mon, 25 Nov 2019 20:49:14 +0530 Subject: [Skiboot-stable] [PATCH] FSP/IPMI: Handle FSP reset reload Message-ID: <20191125151914.29168-1-hegdevasant@linux.vnet.ibm.com> FSP IPMI driver serializes ipmi messages. It sends message to FSP and waits for response before sending new message. It works fine as long as we get response from FSP on time. If we have inflight ipmi message during FSP R/R, we will not get resonse from FSP. So if we initiate inband FSP R/R then all subsequent inband ipmi message gets blocked. Sequence: - ipmitool mc reset cold - - ipmitool <-- gets blocked This patch clears inflight ipmi messages after FSP R/R complete. Signed-off-by: Vasant Hegde Cc: skiboot-stable at lists.ozlabs.org --- hw/fsp/fsp-ipmi.c | 34 ++++++++++++++++++++++++++++++++++ 1 file changed, 34 insertions(+) diff --git a/hw/fsp/fsp-ipmi.c b/hw/fsp/fsp-ipmi.c index 025dd019f..7b20f3cd5 100644 --- a/hw/fsp/fsp-ipmi.c +++ b/hw/fsp/fsp-ipmi.c @@ -70,6 +70,10 @@ static void fsp_ipmi_cmd_done(uint8_t cmd, uint8_t netfn, uint8_t cc) struct fsp_ipmi_msg *fsp_ipmi_msg = fsp_ipmi.cur_msg; lock(&fsp_ipmi.lock); + if (fsp_ipmi.cur_msg == NULL) { + unlock(&fsp_ipmi.lock); + return; + } list_del(&fsp_ipmi_msg->link); fsp_ipmi.cur_msg = NULL; unlock(&fsp_ipmi.lock); @@ -251,6 +255,35 @@ static struct ipmi_backend fsp_ipmi_backend = { .poll = NULL, }; +static bool fsp_ipmi_rr_notify(uint32_t cmd_sub_mod, + struct fsp_msg *msg __unused) +{ + struct ipmi_msg *ipmi_msg; + + switch (cmd_sub_mod) { + case FSP_RESET_START: + return true; + case FSP_RELOAD_COMPLETE: + /* + * We will not get response for outstanding request. Send error + * message to caller and start sending new ipmi messages. + */ + if (fsp_ipmi.cur_msg) { + ipmi_msg = &fsp_ipmi.cur_msg->ipmi_msg; + fsp_ipmi_cmd_done(ipmi_msg->cmd, + IPMI_NETFN_RETURN_CODE(ipmi_msg->netfn), + IPMI_ERR_UNSPECIFIED); + } + fsp_ipmi_send_request(); + return true; + } + return false; +} + +static struct fsp_client fsp_ipmi_client_rr = { + .message = fsp_ipmi_rr_notify, +}; + static bool fsp_ipmi_send_response(uint32_t cmd) { struct fsp_msg *resp; @@ -364,5 +397,6 @@ void fsp_ipmi_init(void) init_lock(&fsp_ipmi.lock); fsp_register_client(&fsp_ipmi_client, FSP_MCLASS_FETCH_SPDATA); + fsp_register_client(&fsp_ipmi_client_rr, FSP_MCLASS_RR_EVENT); ipmi_register_backend(&fsp_ipmi_backend); } -- 2.21.0