[PATCH 1/2] discover: Allow for empty paths

[Jeremy Kerr]

Hi Klaus,

> It's funny, however, that it works (i.e., didn't crash for me on
> the zero-length path scenario)

Yep, from reading your v1 patch, it looked like there was no way for
grub2_parse_file to return a NULL ->path, so I don't think you were
hitting that case.

> > Regardless, in the zero-length path case, -> path is set to NULL,
> > ->dev is not set either, so this function still returns NULL. Are
> > you sure that this fixes the issue in the way that you expect?
> 
> I'm not sure if '()/something' is legal, even less '()'. For
> consistency,

This is regarding an empty path specifier, not an empty device. It looks
like you've addressed that in v3 though.


> can we settle for both dev as well as path can EITHER be zero-length
> (but not both at the same time)?

Yep, I think that's a good approach.

Cheers,


Jeremy
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.ozlabs.org/pipermail/petitboot/attachments/20210121/82cf3a51/attachment.htm>