[PATCH v2 4/5] discover/platform-powerpc: add mailbox message structure

[Jeremy Kerr]

Hi Maxim,

Thanks for your patience while reviewing your patches, I've had a bit of
time to take a look now :)

This series looks good - just one thing to raise with this patch, but
it's pretty minor:

> +typedef struct __attribute__((packed)) {
> +	uint8_t iana[CHASSIS_BOOT_MBOX_IANA_SZ];
> +	uint8_t data[CHASSIS_BOOT_MBOX_BLOCK0_DATA_SZ];
> +} mbox_block0_t;

We generally don't define new typedefs in the petitboot codebase. Can we
just use the struct names instead?

And do they need to be separate structs, or shoud we just have the top-
level 'struct ipmi_mbox_response' ?

[Also, I'm fine with your original patch of keeping these in platform-
powerpc.c, as there's no current users outside of that file. ipmi.h is
fine though, no need to change it if you prefer it as-is].

Cheers,


Jeremy