[PATCH v2 4/5] discover/platform-powerpc: add mailbox message structure

Maxim Polyakov m.polyakov at yadro.com
Mon Jul 15 18:50:13 AEST 2019


08.07.2019 12:04, Maxim Polyakov:

> Hi Geoff, 
> 
> 28.06.2019 18:30, Geoff Levand:
>> Hi Maxim,
>>
>> On 6/26/19 5:37 AM, Maxim Polyakov wrote:
>>> Use structure for the IPMI response mailbox message instead of raw byte
>>> array as its done in the ipmitool utility:
>>> https://github.com/ipmitool/ipmitool/commit/62a04390e10f8e62ce16b7bc95bf6ced419b80eb
>>>
>>> Signed-off-by: Maxim Polyakov <m.polyakov at yadro.com>
>>> ---
>>>  discover/platform-powerpc.c | 83 ++++++++++++++++++++++++++++-----------------
>>>  1 file changed, 52 insertions(+), 31 deletions(-)
>>>
>>
>> It seems these definitions are not specific to powerpc.  Should
>> they go in discover/ipmi.h?
> 
> Ok, I move this code to ipmi.h in the patch v2.
>

This is fixed. Any other comments?

-- 
Regards,
Maxim Polyakov 
Software Engineer, YADRO.


More information about the Petitboot mailing list