[PATCH] discover/boot: abort kexec if lockdown file not present

Brett Grandbois brett.grandbois at opengear.com
Wed May 16 12:55:11 AEST 2018


In gpg_validate_boot_files() after the check to verify that signed boot
is requested, the LOCKDOWN_FILE is then opened and if not accessible
then returns an error code.  The caller (kexec_load) is not checking for
that particular error code (KEXEC_LOAD_SIG_SETUP_INVALID) and will
proceed to kexec the image even though the validation has not been
performed.

Signed-off-by: Brett Grandbois <brett.grandbois at opengear.com>
---
 discover/boot.c | 4 ++++
 1 file changed, 4 insertions(+)

diff --git a/discover/boot.c b/discover/boot.c
index 0da40e3..0042f96 100644
--- a/discover/boot.c
+++ b/discover/boot.c
@@ -83,6 +83,10 @@ static int kexec_load(struct boot_task *boot_task)
 				" verification failure\n", __func__);
 			goto abort_kexec;
 		}
+		if (result == KEXEC_LOAD_SIG_SETUP_INVALID) {
+			/* already logged */
+			goto abort_kexec;
+		}
 	}
 
 	const char* local_initrd = (boot_task->local_initrd_override) ?
-- 
2.7.4



More information about the Petitboot mailing list