[PATCH 0/5] Misc fixes

Joel Stanley joel at jms.id.au
Tue Mar 6 15:02:15 AEDT 2018


Hi Sam,

I built petitboot with clang to see if it helped with the bug I reported
to you today. I found a few things that stopped make check from building,
and scan-build reported a few others.

There are a heap of errors reported with scan-build, but most of them
are not interesting. You might want to give it a go and see for
yourself.

 Bug Type					Quantity
 All Bugs					45

 API
  Argument with 'nonnull' attribute passed null	2

 Dead store
  Dead assignment				14
  Dead increment				15

 Logic error
  Array subscript is undefined			1
  Branch condition evaluates to a garbage value	1
  Called function pointer is null		1
  Dereference of null pointer			8
  Result of operation is garbage or undefined	1

 Memory error
  Use-after-free				2

Joel Stanley (5):
  discover: Fix bad check of version string
  ncurses: Fix bad strncmp
  discover: Fix unused function warning
  test/parser: Fixed uninitialized variable warning
  discover: pxe: Avoid dereferencing null pointer

 discover/device-handler.c |  3 +--
 discover/paths.c          | 13 +++----------
 discover/pxe-parser.c     |  2 +-
 test/parser/utils.c       |  2 +-
 ui/ncurses/nc-cui.c       |  4 ++--
 5 files changed, 8 insertions(+), 16 deletions(-)

-- 
2.15.1



More information about the Petitboot mailing list