[PATCH 3/5] discover/handler: Implement temporary autoboot messages

[Samuel Mendoza-Jonas]

On Tue, 2018-07-10 at 10:18 +0800, Jeremy Kerr wrote:
> Hi Sam,
> 
> > If I'm reading this correctly, applying a temporary autoboot override is
> > a one-time event in that it checks the currently available boot options
> > and sets a default if one matches the device type. But this won't be
> > applied to newly found boot options right?
> 
> We apply to new options too. By setting handler->temp_autoboot (and the
> additions to default_option_priority), we enforce the temporary autoboot
> option on newly discovered options.
> 
> [That's really the core part of the patch; going through the existing
> options to re-find a default is needed too, but there's a bit more code
> involved with that]
> 
> If you like, I can add some comments to better explain this.

Aha, my eyes skipped over the 

> +     handler->temp_autoboot = talloc_steal(handler, opt);

and associated bits.

Don't think it needs a new comment, I just fixed up some wonky indenting
around if (config->ipmi_bootdev) and merged as 99a1f9. Thanks!

> 
> Cheers,
> 
> 
> Jeremy
> _______________________________________________
> Petitboot mailing list
> Petitboot at lists.ozlabs.org
> https://lists.ozlabs.org/listinfo/petitboot