[PATCH] docker: Use host networking

Samuel Mendoza-Jonas sam at mendozajonas.com
Thu Aug 9 11:30:56 AEST 2018


On Wed, 2018-08-08 at 13:12 -0700, Geoff Levand wrote:
> Hi Sam,
> 
> On 08/07/2018 06:08 PM, Samuel Mendoza-Jonas wrote:
> > Use the host driver by default to simplify networking for build-builder,
> > especially when DNS settings need to be inherited from the host.
> 
> Looks OK, but you should update the docker image version.  That
> will change the docker tag, and cause the jenkins job (which runs
> build-builder) to automatically build and use the new image.

Good point, if I merge this together with your strace patch would you
prefer me to increment it to VERSION:="4" or leave it as is?

> 
> diff --git a/docker/builder-include b/docker/builder-include
> index d2d94a4..4f42e2c 100644
> --- a/docker/builder-include
> +++ b/docker/builder-include
> @@ -50,7 +50,7 @@ show_tag () {
>  	echo "${DOCKER_TAG}"
>  }
>  
> -: ${VERSION:="2"}
> +: ${VERSION:="3"}
>  : ${ARCH_TAG:="$(arch_tag)"}
>  : ${DOCKER_NAME:="pb-builder"}
>  : ${DOCKER_TAG:="${DOCKER_NAME}:${VERSION}${ARCH_TAG}"}
> 
> -Geoff
> 




More information about the Petitboot mailing list