[PATCH 1/2] discover: Include leading zero in firmware version string

Cyril Bur cyril.bur at au1.ibm.com
Fri Feb 26 15:42:37 AEDT 2016


On Fri, 26 Feb 2016 12:55:47 +1100
Sam Mendoza-Jonas <sam at mendozajonas.com> wrote:

I notice this is in two places... as long as this won't ever be in a third...

Reviewed-by: Cyril Bur <cyrilbur at gmail.com>

> Signed-off-by: Sam Mendoza-Jonas <sam at mendozajonas.com>
> ---
>  discover/platform-powerpc.c | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/discover/platform-powerpc.c b/discover/platform-powerpc.c
> index 98deea5..0e3a10b 100644
> --- a/discover/platform-powerpc.c
> +++ b/discover/platform-powerpc.c
> @@ -1066,7 +1066,7 @@ static void get_ipmi_bmc_versions(struct platform *p, struct system_info *info)
>  		bcd += 10 * (resp[4] >> 4);
>  		memcpy(&aux_version, &resp[12], sizeof(aux_version));
>  		info->bmc_current[2] = talloc_asprintf(info,
> -						"Firmware version: %u.%u.%u",
> +						"Firmware version: %u.%02u.%u",
>  						resp[3], bcd, aux_version);
>  		bcd = resp[5] & 0x0f;
>  		bcd += 10 * (resp[5] >> 4);
> @@ -1104,7 +1104,7 @@ static void get_ipmi_bmc_versions(struct platform *p, struct system_info *info)
>  		bcd += 10 * (resp[4] >> 4);
>  		memcpy(&aux_version, &resp[12], sizeof(aux_version));
>  		info->bmc_golden[2] = talloc_asprintf(info,
> -						"Firmware version: %u.%u.%u",
> +						"Firmware version: %u.%02u.%u",
>  						resp[3], bcd, aux_version);
>  		bcd = resp[5] & 0x0f;
>  		bcd += 10 * (resp[5] >> 4);



More information about the Petitboot mailing list