[PATCH 3/3] lib/talloc: Avoid early exit before va_end()
Sam Mendoza-Jonas
sam at mendozajonas.com
Tue Feb 9 13:08:45 AEDT 2016
From: Samuel Mendoza-Jonas <sam.mj at au1.ibm.com>
Fixes Coverity defect #30486
Signed-off-by: Sam Mendoza-Jonas <sam at mendozajonas.com>
---
lib/talloc/talloc.c | 4 +++-
1 file changed, 3 insertions(+), 1 deletion(-)
diff --git a/lib/talloc/talloc.c b/lib/talloc/talloc.c
index fa34323..f233541 100644
--- a/lib/talloc/talloc.c
+++ b/lib/talloc/talloc.c
@@ -1032,13 +1032,15 @@ static char *talloc_vasprintf_append(char *s, const char *fmt, va_list ap)
len = vsnprintf(NULL, 0, fmt, ap2);
s = talloc_realloc(NULL, s, char, s_len + len+1);
- if (!s) return NULL;
+ if (!s)
+ goto out;
VA_COPY(ap2, ap);
vsnprintf(s+s_len, len+1, fmt, ap2);
talloc_set_name_const(s, s);
+out:
va_end(ap2);
return s;
}
--
2.7.1
More information about the Petitboot
mailing list