[PATCH 3/3] [V6] Add encrypted file support

[Timothy Pearson]

-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

On 08/16/2016 10:47 PM, Samuel Mendoza-Jonas wrote:
> Previous comment about strncmp() applies here too

Previous comment about this comment applies here too. :-)

> Is some cleanup being skipped here?

Yep!  Fixed in patch V7.

> Same comment from before about break-ing

Fixed in patch V7.

> No need for else {}. Does it make sense to return an error before the
> copy loop above?

Fixed in patch V7.  I'd prefer to leave the copy / error sequence as-is
for future flexibility.

> if () {
> 	// foo
> } else {
> 	// bar
> }

This particular instance was fixed in patch V7.  Not sure if any other
instances remain; this is not our normal coding style so there may be
other examples.

> Same comment about strncmp()

Same comment to the comment.

> These nc-boot-editor changes look like they should be in the first patch?

Oops!  Fixed in patch V7.

- -- 
Timothy Pearson
Raptor Engineering
+1 (415) 727-8645 (direct line)
+1 (512) 690-0200 (switchboard)
https://www.raptorengineering.com
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.11 (GNU/Linux)
Comment: Using GnuPG with Mozilla - http://enigmail.mozdev.org/

iQEcBAEBAgAGBQJXtYRqAAoJEK+E3vEXDOFbBAwH/1voxNnsHPSX7O2d5y7osgO3
yWJ7ZyMxt4n9YbGdjB8kUWJwwc0d2SZXC8+40eQnHkHTSVzbXaufASFHLQKW148a
v3eYpU2/SVF0Pec8bQykRgx7dNFd/NXUIz+ONZj1+EEvuSoD8LQKI9KnON254NRj
Hsb7nhkNsF8Nl6/OkYX+3csGvMh1D2rHub0n3WMRM56VKHz7jr9DXDsUfXmc2+9/
sv9k3qi7Q16LuT/m3iVbxYOXt+4mnhNYxQC1Plyw0b4oGVNOT6PVhKt0dTVEYbEo
K5rF/ny8aSNEe4NfW/1iT4G9rhg7K1eUeXffnE6s0YkdfKwdGPMrTf9GTXi9Q0Y=
=az3Y
-----END PGP SIGNATURE-----