[PATCH 00/11] Several Coverity Fixes
Samuel Mendoza-Jonas
sam.mj at au1.ibm.com
Thu Nov 12 15:34:30 AEDT 2015
We now have Coverity for Petitboot! The first scan resulted in 40 defects, but nothing particulary concerning. However a happy code analyser is good for everyone, so several of these defects are patched below.
The Coverity project is available here; please send me a message if you would like acccess.
https://scan.coverity.com/projects/petitboot?tab=overview
Samuel Mendoza-Jonas (11):
discover: Properly handle return values
discover: Use snprintf() when building sysparam path
ui/ncurses: Check for NULL in pmenu_item_get_index()
discover: Fix dead code in udev_handle_cdrom_events()
lib/talloc: Add missing va_end() calls
ui/common: Free message on return
discover: Skip malformed bootdev fields
discover: Add two missing talloc_free()s
discover: Null-terminate buffer in user_event_process()
discover: Set umask before mkstemp()
ui/ncurses: Remove redundant assignment
discover/device-handler.c | 6 ++----
discover/dt.c | 1 +
discover/ipmi.c | 3 ++-
discover/parser.c | 1 +
discover/paths.c | 10 ++++++++--
discover/platform-powerpc.c | 19 +++++++------------
discover/udev.c | 9 ++-------
discover/user-event.c | 6 ++++--
lib/talloc/talloc.c | 2 ++
ui/common/discover-client.c | 13 +++++++------
ui/ncurses/nc-menu.c | 7 ++++---
ui/ncurses/nc-widgets.c | 4 +---
12 files changed, 41 insertions(+), 40 deletions(-)
--
2.6.2
More information about the Petitboot
mailing list