[PATCH 5/9] lib: Add libxml2 support

[Sam Mendoza-Jonas]

On Wed, Dec 16, 2015 at 04:08:01PM +1100, Stewart Smith wrote:
> Samuel Mendoza-Jonas <sam.mj at au1.ibm.com> writes:
> > Attribute override functionality on BMC machines will require parsing a
> > Hostboot-provided XML file on startup. This adds generic libxml2 support
> > in order to parse these files.
> >
> > Signed-off-by: Samuel Mendoza-Jonas <sam.mj at au1.ibm.com>
> > ---
> >  lib/Makefile.am |   7 ++-
> >  lib/xml/xml.c   | 152 ++++++++++++++++++++++++++++++++++++++++++++++++++++++++
> >  lib/xml/xml.h   |  19 +++++++
> >  3 files changed, 177 insertions(+), 1 deletion(-)
> >  create mode 100644 lib/xml/xml.c
> >  create mode 100644 lib/xml/xml.h
> >
> > diff --git a/lib/Makefile.am b/lib/Makefile.am
> > index a3ae943..ea6e5c7 100644
> > --- a/lib/Makefile.am
> > +++ b/lib/Makefile.am
> > @@ -49,20 +49,25 @@ lib_libpbcore_la_SOURCES = \
> >  	lib/url/url.h \
> >  	lib/util/util.c \
> >  	lib/util/util.h \
> > +	lib/xml/xml.h \
> >  	lib/flash/config.h \
> >  	lib/flash/flash.h
> >  
> >  if ENABLE_MTD
> >  lib_libpbcore_la_SOURCES += \
> > +	lib/xml/xml.c \
> >  	lib/flash/flash.c
> >  
> >  lib_libpbcore_la_CPPFLAGS += \
> > +	`xml2-config --cflags` \
> >  	$(AM_CPPFLAGS)
> >  
> >  lib_libpbcore_la_LDFLAGS = \
> > +	`xml2-config --libs` \
> >  	$(AM_LDFLAGS) \
> >  	-l:libflash.so
> 
> Instead of calling xml2-config directly, there should be some autoconf
> foo to do that. It doesn't do pkg-config by any chance does it?
> 

That's a good point - this carried through from when I was originally
working with it locally, but it *should* be sufficient to just put
-l:lxml2 - I'll test this in op-build.