[PATCH 0/9] Support for BMC platform versions and attributes

[Cyril Bur]

On Tue, 15 Dec 2015 14:15:21 +1100
Samuel Mendoza-Jonas <sam.mj at au1.ibm.com> wrote:

Hi Sam,

Had a quick look at the series, overall looks good. There's a mix of things so
if I don't respond at all to the patch it's because I don't really know
anything at all to be of value there. Otherwise comments in each patch.

Cyril

> This is a reorganised version of the previous RFC "Support for Hostboot Attributes",
> adding support for parsing of the VERSION partition of the PNOR on BMC
> machines, and including better building rules.
> 
> Patches 01-04 add VERSION support and are complete.
> Patches 05-09 add ATTR_PERM (attribute override) support, and are feature-complete
> barring some potential style or semantic changes.
> 
> These are also available separately on Github at
> https://github.com/sammj/petitboot/tree/firmware_version
> and
> https://github.com/sammj/petitboot/tree/firmware_attribute
> 
> Samuel Mendoza-Jonas (9):
>   Add --enable-mtd configure option
>   lib: Add CCAN headers for endian helpers
>   lib/flash: Add support for platform versions
>   Display VERSION partition info on BMC machines
>   lib: Add libxml2 support
>   lib: Add types for platform attributes
>   lib/flash: Add support for ATTR_PERM partition on BMC machines
>   discover: Expose and configure Attribute Overrides
>   ui: Support FIRMWARE messages and add ncurses/hostboot
> 
>  configure.ac                               |  15 +
>  discover/Makefile.am                       |  17 +
>  discover/device-handler.c                  |  37 ++
>  discover/device-handler.h                  |   2 +
>  discover/discover-server.c                 |  36 ++
>  discover/hostboot.c                        | 351 ++++++++++++++
>  discover/hostboot.h                        |  33 ++
>  discover/platform-powerpc.c                |  42 ++
>  discover/platform.c                        |  23 +
>  discover/platform.h                        |   6 +
>  lib/Makefile.am                            |  24 +-
>  lib/ccan/endian/.depends                   |   0
>  lib/ccan/endian/LICENSE                    |  28 ++
>  lib/ccan/endian/_info                      |  55 +++
>  lib/ccan/endian/endian.h                   | 346 ++++++++++++++
>  lib/ccan/endian/test/compile_ok-constant.c |  12 +
>  lib/ccan/endian/test/run.c                 | 109 +++++
>  lib/flash/config.h                         |  19 +
>  lib/flash/flash.c                          | 707 +++++++++++++++++++++++++++++
>  lib/flash/flash.h                          |  48 ++
>  lib/pb-protocol/pb-protocol.c              | 381 ++++++++++++++++
>  lib/pb-protocol/pb-protocol.h              |   7 +
>  lib/types/types.h                          |  62 +++
>  lib/xml/xml.c                              | 152 +++++++
>  lib/xml/xml.h                              |  19 +
>  ui/common/discover-client.c                |  36 ++
>  ui/common/discover-client.h                |   5 +
>  ui/ncurses/Makefile.am                     |   5 +-
>  ui/ncurses/nc-cui.c                        |  55 ++-
>  ui/ncurses/nc-cui.h                        |   5 +
>  ui/ncurses/nc-firmware-help.c              |   4 +
>  ui/ncurses/nc-firmware.c                   | 677 +++++++++++++++++++++++++++
>  ui/ncurses/nc-firmware.h                   |  34 ++
>  ui/ncurses/nc-scr.h                        |   1 +
>  ui/ncurses/nc-sysinfo.c                    |   7 +
>  ui/ncurses/nc-widgets.c                    |   4 +-
>  ui/ncurses/nc-widgets.h                    |   4 +-
>  37 files changed, 3357 insertions(+), 11 deletions(-)
>  create mode 100644 discover/hostboot.c
>  create mode 100644 discover/hostboot.h
>  create mode 100644 lib/ccan/endian/.depends
>  create mode 100644 lib/ccan/endian/LICENSE
>  create mode 100644 lib/ccan/endian/_info
>  create mode 100644 lib/ccan/endian/endian.h
>  create mode 100644 lib/ccan/endian/test/compile_ok-constant.c
>  create mode 100644 lib/ccan/endian/test/run.c
>  create mode 100644 lib/flash/config.h
>  create mode 100644 lib/flash/flash.c
>  create mode 100644 lib/flash/flash.h
>  create mode 100644 lib/xml/xml.c
>  create mode 100644 lib/xml/xml.h
>  create mode 100644 ui/ncurses/nc-firmware-help.c
>  create mode 100644 ui/ncurses/nc-firmware.c
>  create mode 100644 ui/ncurses/nc-firmware.h
>