[PATCH] ui/ncurses: Prevent crash if bd->image NULL

Sam Mendoza-Jonas sam.mj at au1.ibm.com
Wed Jul 23 09:47:06 EST 2014


On 22/07/14 18:50, Jeremy Kerr wrote:
> Hi Sam,
>
>> The discover server can pass boot options with no actual
>> boot data if parsing conf files such as:
>>
>> label Dummy entry
>>
>> label Rexec petitboot latest
>> 	kernel tftp://host/petitboot/vmlinux
>> 	initrd tftp://host/petitboot/rootfs.cpio.xz
>
> This shouldn't be allowed - we (currently) require that at least ->image
> is set for a boot_option. If that's not the case, we need to fix the
> boot options that are being created here.

After a quick look, it seems the grub parser does check, but it looks 
like it could sneak past pxe_parser and yaboot_parser.

I'll add in checks where needed - would you like me to keep this check
in ncurses as well?

>
> Cheers,
>
>
> Jeremy
>


-- 
-----------
LTC Ozlabs
IBM



More information about the Petitboot mailing list