[Pdbg] [PATCH v2 00/39] gdbserver multi-threaded debugging and POWER9/10 support

[Joel Stanley]

On Tue, 10 May 2022 at 09:47, Nicholas Piggin <npiggin at gmail.com> wrote:
>
> Excerpts from Joel Stanley's message of May 3, 2022 5:47 pm:
> > On Wed, 20 Apr 2022 at 06:50, Nicholas Piggin <npiggin at gmail.com> wrote:
> >>
> >> POWER10 is working well with sbefifo (modulo the start SBE command
> >> being buggy with stop states -- make sure you use powersave=off when
> >> testing this, until those can be fixed). POWER9 similarly works well,
> >> with the exception of breakpoints causing PSI interrupt storm.
> >>
> >> gdbserver itself was due for a bit of attention so there's a bunch of
> >> improvements and fixes.
> >>
> >> Multi-threaded debugging is implemented later in the series using the
> >> gdb "all-stop" threads model (all target threads are stopped if any is
> >> stopped).
> >>
> >> Since v1:
> >> - Made changes suggested by Joel (thanks).
> >> - Made a generated target, split out the regen of the stale
> >>   gdb_parser_precompile.c into that patch.
> >> - Make the double-ctrl-C really immediately kill.
> >> - Implemented multi-threaded debugging.
> >> - A few more smaller improvements (put_mem handling, breakpoint
> >>   command handling, returning more registers).
> >> - Redudce round trips further by returning registers with stop reason.
> >> - POWER9 support as well.
> >> - Proper SPATTN / attn detection and clearing for POWER9/10.
> >
> > Looking good. Unless there's things you want to fix on the first go,
> > I'll merge these and you can send any improvements as follow up
> > patches?
>
> Thanks for the review, sorry it took so long to get around to replying.
>
> You raised some good points but if I can address them incrementally
> might be easier.

I've merged them. I'll do a bit more testing before pushing them out.

Thanks for all the hard work.

Cheers,

Joel