[Pdbg] [PATCH v2 08/38] gdbserver: use standard compatibility test calls
Nicholas Piggin
npiggin at gmail.com
Wed Mar 30 02:49:01 AEDT 2022
p10.dts.m4 defines compatible = "ibm,power-thread", "ibm,power10-thread"
which fails to match on a basic strcmp.
Aside, find_driver in hwunit.c looks like the only other place that does
a strcmp on compatible. I wonder if that should be changed as well?
Signed-off-by: Nicholas Piggin <npiggin at gmail.com>
---
src/pdbgproxy.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/src/pdbgproxy.c b/src/pdbgproxy.c
index 5a8b5f9..906ed2f 100644
--- a/src/pdbgproxy.c
+++ b/src/pdbgproxy.c
@@ -532,8 +532,8 @@ static int gdbserver(uint16_t port)
//
// Temporary until I can get this working a bit smoother on p9
- if (strcmp(thread->compatible, "ibm,power8-thread")) {
- PR_ERROR("GDBSERVER is only tested on POWER8\n");
+ if (!pdbg_target_compatible(thread, "ibm,power8-thread")) {
+ PR_ERROR("GDBSERVER is only available on POWER8\n");
return -1;
}
--
2.23.0
More information about the Pdbg
mailing list