[Pdbg] [PATCH 05/14] gdbclient: use standard compatibility test calls

Joel Stanley joel at jms.id.au
Wed Mar 16 10:13:44 AEDT 2022


On Mon, 14 Mar 2022 at 04:18, Nicholas Piggin <npiggin at gmail.com> wrote:
>
> Signed-off-by: Nicholas Piggin <npiggin at gmail.com>
> ---
>  src/pdbgproxy.c | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/src/pdbgproxy.c b/src/pdbgproxy.c
> index 5a8b5f9..906ed2f 100644
> --- a/src/pdbgproxy.c
> +++ b/src/pdbgproxy.c
> @@ -532,8 +532,8 @@ static int gdbserver(uint16_t port)
>
>         //
>         // Temporary until I can get this working a bit smoother on p9
> -       if (strcmp(thread->compatible, "ibm,power8-thread")) {
> -               PR_ERROR("GDBSERVER is only tested on POWER8\n");
> +       if (!pdbg_target_compatible(thread, "ibm,power8-thread")) {

This calls through a lot more code to do what looks like the same
thing. I assume it's the correct thing to do though.


> +               PR_ERROR("GDBSERVER is only available on POWER8\n");
>                 return -1;
>         }
>
> --
> 2.23.0
>
> --
> Pdbg mailing list
> Pdbg at lists.ozlabs.org
> https://lists.ozlabs.org/listinfo/pdbg


More information about the Pdbg mailing list