[Pdbg] [PATCH v2 07/20] tests: Add fapi p10 address translation tests

[Amitay Isaacs]

On Wed, 2020-10-07 at 11:46 +0000, Joel Stanley wrote:
> On Thu, 1 Oct 2020 at 07:11, Amitay Isaacs <amitay at ozlabs.org> wrote:
> 
> > +++ b/src/tests/libpdbg_p10_fapi_translation_test.C
> > @@ -0,0 +1,113 @@
> > +#include <stdio.h>
> > +#include <inttypes.h>
> > +
> > +#define class klass
> > +#include "libpdbg/libpdbg.h"
> > +#include "libpdbg/hwunit.h"
> > +#include "libpdbg/target.h"
> > +#undef class
> > +
> > +#include "p10_scominfo.H"
> > +
> > +#define MAX_INDEX 30
> > +
> > +int test_unit_translation(struct pdbg_target *target,
> > p10ChipUnits_t cu, int index, uint64_t addr)
> > +{
> > +       uint64_t pdbg_addr, fapi_addr;
> > +
> > +       target->index = index;
> > +
> > +       /* TODO: Check standard chiplet translation */
> > +       if (!target->translate)
> > +               return 1;
> 
> Is this still a TODO?

Yes.  I need to fix that for both P9 and P10.  However, the main reason
for these tests is to confirm the special translation required for some
of the hardware units is correct.

> 
> Reviewed-by: Joel Stanley <joel at jms.id.au>
> 
> 
> 
> > +
> > +       if (validateChipUnitNum(index, cu))
> > +               return 1;
> > +

Amitay.
-- 

Not in time, place or circumstance, but in man lies success. - Charles Rouce