[Pdbg] [PATCH 09/11] tests: Remove unnecessary include and dependency

Alistair Popple alistair at popple.id.au
Wed May 6 10:59:41 AEST 2020


Reviewed-by: Alistair Popple  <alistair at popple.id.au>

On Thursday, 30 April 2020 1:05:42 PM AEST Amitay Isaacs wrote:
> Signed-off-by: Amitay Isaacs <amitay at ozlabs.org>
> ---
>  Makefile.am                     | 4 ----
>  src/tests/libpdbg_probe_test.c  | 2 --
>  src/tests/libpdbg_target_test.c | 2 --
>  3 files changed, 8 deletions(-)
> 
> diff --git a/Makefile.am b/Makefile.am
> index 64f3e0b..babb82c 100644
> --- a/Makefile.am
> +++ b/Makefile.am
> @@ -243,8 +243,6 @@ libpdbg_target_test_CFLAGS = $(libpdbg_test_cflags)
>  libpdbg_target_test_LDFLAGS = $(libpdbg_test_ldflags)
>  libpdbg_target_test_LDADD = $(libpdbg_test_ldadd)
> 
> -src/tests/libpdbg_target_test.c: fake.dt.h
> -
>  libpdbg_probe_test1_SOURCES = src/tests/libpdbg_probe_test.c
>  libpdbg_probe_test1_CFLAGS = $(libpdbg_test_cflags) -DTEST_ID=1
>  libpdbg_probe_test1_LDFLAGS = $(libpdbg_test_ldflags)
> @@ -260,8 +258,6 @@ libpdbg_probe_test3_CFLAGS = $(libpdbg_test_cflags)
> -DTEST_ID=3 libpdbg_probe_test3_LDFLAGS = $(libpdbg_test_ldflags)
>  libpdbg_probe_test3_LDADD = $(libpdbg_test_ldadd)
> 
> -src/tests/libpdbg_probe_test.c: fake.dt.h
> -
>  libpdbg_dtree_test_SOURCES = src/tests/libpdbg_dtree_test.c
>  libpdbg_dtree_test_CFLAGS = $(libpdbg_test_cflags)
>  libpdbg_dtree_test_LDFLAGS = $(libpdbg_test_ldflags)
> diff --git a/src/tests/libpdbg_probe_test.c b/src/tests/libpdbg_probe_test.c
> index c76f77f..cdefddd 100644
> --- a/src/tests/libpdbg_probe_test.c
> +++ b/src/tests/libpdbg_probe_test.c
> @@ -20,8 +20,6 @@
> 
>  #include <libpdbg.h>
> 
> -#include "fake.dt.h"
> -
>  static void for_each_target(struct pdbg_target *parent,
>  			    void (*callback)(struct pdbg_target *target,
>  					     enum pdbg_target_status status),
> diff --git a/src/tests/libpdbg_target_test.c
> b/src/tests/libpdbg_target_test.c index 36e6891..d7ffbd2 100644
> --- a/src/tests/libpdbg_target_test.c
> +++ b/src/tests/libpdbg_target_test.c
> @@ -21,8 +21,6 @@
> 
>  #include <libpdbg.h>
> 
> -#include "fake.dt.h"
> -
>  static int count_target(struct pdbg_target *parent, const char *classname)
>  {
>  	struct pdbg_target *target;






More information about the Pdbg mailing list