[Pdbg] [PATCH] libfdt: Install libfdt header files

[Amitay Isaacs]

On Wed, 2020-03-04 at 15:18 +1100, Alistair Popple wrote:
> On Wednesday, 4 March 2020 3:15:27 PM AEDT Amitay Isaacs wrote:
> > On Wed, 2020-03-04 at 14:44 +1100, Alistair Popple wrote:
> > > What did we need this for? Do we leak abstractions from libfdt
> > > into
> > > the
> > > libpdbg API?
> > 
> > This is required if you don't have system installed fdt.  If you
> > are
> > using the bundled version of libfdt, then make install would not
> > install fdt header files.
> 
> Right, but does the libpdbg API require the libfdt header files? I'm
> just 
> concerned about other programs finding the pdbg built ones and
> linking against 
> them instead of just installing whatever the system distro version
> is.

No.  But pdata requires libfdt headers and when cross-compiling phal
(without openbmc build), there are no libfdt headers installed.  So we
use the libfdt headers from bundled fdt library in pdbg.

If the system has fdt library installed, then pdbg would automatically
use the system installed library and not the bundled one.

> 
> - Alistair
> 
> > > - Alistair
> > > 
> > > On Wednesday, 20 November 2019 6:26:27 PM AEDT Amitay Isaacs
> > > wrote:
> > > > Signed-off-by: Amitay Isaacs <amitay at ozlabs.org>
> > > > ---
> > > > 
> > > >  libfdt/Makefile.am | 2 ++
> > > >  1 file changed, 2 insertions(+)
> > > > 
> > > > diff --git a/libfdt/Makefile.am b/libfdt/Makefile.am
> > > > index df82d55..17c7348 100644
> > > > --- a/libfdt/Makefile.am
> > > > +++ b/libfdt/Makefile.am
> > > > @@ -5,6 +5,8 @@ ACLOCAL_AMFLAGS = -Im4
> > > > 
> > > >  lib_LTLIBRARIES = libfdt.la
> > > > 
> > > > +include_HEADERS = libfdt.h libfdt_env.h fdt.h
> > > > +
> > > > 
> > > >  libfdt_la_SOURCES = \
> > > >  
> > > >  	fdt_addresses.c \
> > > >  	fdt.c \
> > 
> > Amitay.
> 
> 
> 

Amitay.
-- 

I knew who I was when I got up this morning,
But I must have changed several times since then.