[Pdbg] [PATCH 2/2] libpdbg: Replace hard-coded chip id with defines

Alistair Popple alistair at popple.id.au
Mon Jun 15 17:39:11 AEST 2020


Reviewed-by: Alistair Popple <alistair at popple.id.au>

On Tuesday, 26 May 2020 3:13:12 PM AEST Amitay Isaacs wrote:
> Signed-off-by: Amitay Isaacs <amitay at ozlabs.org>
> ---
>  libpdbg/cfam.c | 6 +++---
>  1 file changed, 3 insertions(+), 3 deletions(-)
> 
> diff --git a/libpdbg/cfam.c b/libpdbg/cfam.c
> index 0b0b6f0..0b670d8 100644
> --- a/libpdbg/cfam.c
> +++ b/libpdbg/cfam.c
> @@ -241,11 +241,11 @@ DECLARE_HW_UNIT(p8_opb);
>  enum chip_type get_chip_type(uint64_t chip_id)
>  {
>  	switch(GETFIELD(PPC_BITMASK32(12, 19), chip_id)) {
> -	case 0xea:
> +	case CHIP_ID_P8:
>  		return CHIP_P8;
> -	case 0xd3:
> +	case CHIP_ID_P8P:
>  		return CHIP_P8NV;
> -	case 0xd1:
> +	case CHIP_ID_P9:
>  		return CHIP_P9;
>  	default:
>  		return CHIP_UNKNOWN;
> 






More information about the Pdbg mailing list