[Pdbg] [PATCH v2 6/7] libpdbg: If device path does not exist, log at INFO level

Alistair Popple alistair at popple.id.au
Mon Jun 15 17:32:32 AEST 2020


Thanks for fixing. Probe gets called in contexts where failure is expected so 
there should never be errors there.

Reviewed-by: Alistair Popple <alistair at popple.id.au>

On Wednesday, 10 June 2020 3:24:25 PM AEST Amitay Isaacs wrote:
> Signed-off-by: Amitay Isaacs <amitay at ozlabs.org>
> ---
>  libpdbg/kernel.c | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/libpdbg/kernel.c b/libpdbg/kernel.c
> index c63ef93..b2b977b 100644
> --- a/libpdbg/kernel.c
> +++ b/libpdbg/kernel.c
> @@ -186,7 +186,7 @@ int kernel_fsi_probe(struct pdbg_target *target)
>  		}
>  	}
>  
> -	PR_ERROR("Unable to open %s\n", path);
> +	PR_INFO("Unable to open %s\n", path);
>  	free(path);
>  	return -1;
>  }
> @@ -250,7 +250,7 @@ static int kernel_pib_probe(struct pdbg_target *target)
>  
>  	pib->fd = open(scom_path, O_RDWR | O_SYNC);
>  	if (pib->fd < 0) {
> -		PR_ERROR("Unable to open %s\n", scom_path);
> +		PR_INFO("Unable to open %s\n", scom_path);
>  		return -1;
>  	}
>  
> 






More information about the Pdbg mailing list