[Pdbg] [PATCH v2 2/7] libpdbg: Do not hard-code fsi device path

Alistair Popple alistair at popple.id.au
Mon Jun 15 17:26:35 AEST 2020


Technically this and the next patch should be rolled into one to avoid 
breaking anything.

Reviewed-by: Alistair Popple <alistair at popple.id.au>

On Wednesday, 10 June 2020 3:24:21 PM AEST Amitay Isaacs wrote:
> Signed-off-by: Amitay Isaacs <amitay at ozlabs.org>
> ---
>  libpdbg/kernel.c | 6 +++++-
>  1 file changed, 5 insertions(+), 1 deletion(-)
> 
> diff --git a/libpdbg/kernel.c b/libpdbg/kernel.c
> index 7914e50..2cc81f2 100644
> --- a/libpdbg/kernel.c
> +++ b/libpdbg/kernel.c
> @@ -147,12 +147,16 @@ int kernel_fsi_probe(struct pdbg_target *target)
>  	int tries = 5;
>  	int rc;
>  	const char *kernel_path = kernel_get_fsi_path();
> +	const char *fsi_path;
>  	char *path;
>  
>  	if (!kernel_path)
>  		return -1;
>  
> -	rc = asprintf(&path, "%s/fsi0/slave at 00:00/raw", kernel_get_fsi_path());
> +	fsi_path = pdbg_target_property(target, "device-path", NULL);
> +	assert(fsi_path);
> +	rc = asprintf(&path, "%s%s", kernel_get_fsi_path(), fsi_path);
>  	if (rc < 0) {
>  		PR_ERROR("Unable create fsi path\n");
>  		return rc;
> 






More information about the Pdbg mailing list