[Pdbg] [PATCH 07/13] libpdbg: Do not store properties in linked list

Alistair Popple alistair at popple.id.au
Thu Jan 16 12:38:00 AEDT 2020


>  static void dt_link_virtual(struct pdbg_target *node, struct pdbg_target
> *vnode) {
> -	struct dt_property *prop = NULL, *next;
> -
>  	node->vnode = vnode;
>  	vnode->vnode = node;
> -
> -	/* Move any properties on virtual node to real node */
> -	list_for_each_safe(&vnode->properties, prop, next, list) {
> -		if (!strcmp(prop->name, "#address-cells") || !strcmp(prop->name,
> "#size-cells")) -			continue;
> -
> -		list_del(&prop->list);
> -		list_add_tail(&node->properties, &prop->list);
> -	}

We're changing the behaviour here right? We should probably figure out why we 
did this and make sure it's safe to stop doing it, or change the property 
reading code to make sure it looks at the virtual node as well when trying to 
access properties.

- Alistair

>  }
> 
>  static void pdbg_targets_init_virtual(struct pdbg_target *node, struct
> pdbg_target *root)






More information about the Pdbg mailing list