[Pdbg] [PATCH 03/13] Revert "libpdbg.h: Expose method to read fdt pointer"

Amitay Isaacs amitay at ozlabs.org
Wed Jan 15 16:18:51 AEDT 2020


This reverts commit 376e498fb5a69afd5a2a0349bd3a37dd774a225e.

Instead of exposing the internal structures, add an api to get system
device tree.
---
 libpdbg/libpdbg.h | 5 -----
 libpdbg/target.h  | 6 ++++++
 2 files changed, 6 insertions(+), 5 deletions(-)

diff --git a/libpdbg/libpdbg.h b/libpdbg/libpdbg.h
index 6fd16f3..4a8f1cf 100644
--- a/libpdbg/libpdbg.h
+++ b/libpdbg/libpdbg.h
@@ -102,11 +102,6 @@ uint64_t pdbg_target_address(struct pdbg_target *target, uint64_t *size);
 	(index == 0 ? pdbg_target_address(target, size) : assert(0))
 
 /* Misc. */
-struct pdbg_dtb {
-	void *backend;
-	void *system;
-};
-void pdbg_default_dtb(struct pdbg_dtb *pdtb, void *system_fdt);
 bool pdbg_targets_init(void *fdt);
 void pdbg_target_probe_all(struct pdbg_target *parent);
 enum pdbg_target_status pdbg_target_probe(struct pdbg_target *target);
diff --git a/libpdbg/target.h b/libpdbg/target.h
index 9e25a43..f068e8d 100644
--- a/libpdbg/target.h
+++ b/libpdbg/target.h
@@ -55,6 +55,11 @@ struct pdbg_target {
 	struct pdbg_target *vnode;
 };
 
+struct pdbg_dtb {
+	void *backend;
+	void *system;
+};
+
 struct pdbg_target *get_parent(struct pdbg_target *target, bool system);
 struct pdbg_target *target_parent(const char *klass, struct pdbg_target *target, bool system);
 struct pdbg_target *require_target_parent(const char *klass, struct pdbg_target *target, bool system);
@@ -66,6 +71,7 @@ bool pdbg_target_is_class(struct pdbg_target *target, const char *class);
 extern struct list_head empty_list;
 extern struct list_head target_classes;
 
+void pdbg_default_dtb(struct pdbg_dtb *pdtb, void *system_fdt);
 const char *pdbg_get_backend_option(void);
 
 struct chipop *pib_to_chipop(struct pdbg_target *target);
-- 
2.21.1



More information about the Pdbg mailing list