[Pdbg] [PATCH v4 16/30] libpdbg: Probe should traverse virtual nodes also

Alistair Popple alistair at popple.id.au
Wed Oct 9 15:16:14 AEDT 2019


> +	/* Make sure any virtual nodes are also probed */
> +	vnode = target_to_virtual(target);
> +	if (vnode && vnode != target)
> +		pdbg_target_probe(vnode);

Personally I think it might be clearer and less surprising if 
target_to_virtual/real() returned NULL in cases when they can't find a target 
of the correct type. That way any future callers are forced to think about 
what to do in those cases.

- Alistair

>  	/* At this point any parents must exist and have already been probed */
>  	if (target->probe && target->probe(target)) {
>  		/* Could not find the target */
> 






More information about the Pdbg mailing list