[Pdbg] [PATCH v4 11/30] libpdbg: Construct unique path based on virtual nodes

Alistair Popple alistair at popple.id.au
Wed Oct 9 13:38:49 AEDT 2019


Reviewed-by: Alistair Popple <alistair at popple.id.au>

On Thursday, 3 October 2019 2:18:50 PM AEDT Amitay Isaacs wrote:
> Even though there can be two different paths to a node, libpdbg users
> should always see the path as defined in system device tree (view) which
> is the same and independent of the backend device tree.
> 
> Signed-off-by: Amitay Isaacs <amitay at ozlabs.org>
> ---
>  libpdbg/device.c | 2 ++
>  1 file changed, 2 insertions(+)
> 
> diff --git a/libpdbg/device.c b/libpdbg/device.c
> index 2a02504..2f3d677 100644
> --- a/libpdbg/device.c
> +++ b/libpdbg/device.c
> @@ -219,6 +219,7 @@ static char *dt_get_path(struct pdbg_target *node)
>  		return strdup("<NULL>");
>  
>  	for (n = node; n; n = n->parent) {
> +		n = target_to_virtual(n);
>  		len += strlen(n->dn_name);
>  		if (n->parent || n == node)
>  			len++;
> @@ -227,6 +228,7 @@ static char *dt_get_path(struct pdbg_target *node)
>  	assert(path);
>  	p = path + len;
>  	for (n = node; n; n = n->parent) {
> +		n = target_to_virtual(n);
>  		len = strlen(n->dn_name);
>  		p -= len;
>  		memcpy(p, n->dn_name, len);
> 






More information about the Pdbg mailing list