[Pdbg] [PATCH] htm: Fixed '-l' option to work as intended with new probing

[Amitay Isaacs]

On Wed, 2019-06-12 at 16:11 +1000, Rashmica Gupta wrote:
> This option was added for htm core tracing so we want the core to be
> targeted, not the thread.

Even though it might be added for htm, some one can use it legitimately
for other operations where threads are expected and would get strange
results.

I think it would be better to add all the entities (pib/core/thread) as
we do for p/c/t options.

HTM code can then only use selected core target(s).

> 
> Signed-off-by: Rashmica Gupta <rashmica.g at gmail.com>
> Acked-by: Michael Neuling <mikey at neuling.org>
> ---
>  src/main.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/src/main.c b/src/main.c
> index d5f9385..53ad99f 100644
> --- a/src/main.c
> +++ b/src/main.c
> @@ -517,7 +517,7 @@ static bool parse_options(int argc, char *argv[])
>  
>  				pir_map(pir, &chip, &core, &thread);
>  
> -				if
> (!pathsel_add("pib%d/core%d/thread%d", chip, core, thread))
> +				if (!pathsel_add("pib%d/core%d", chip,
> core))
>  					return false;
>  			}
>  		}
> -- 
> 2.17.2
> 

Amitay.
-- 

First you forget names, then you forget faces, then you forget to pull your
zipper up, then you forget to pull your zipper down. - Leo Rosenburg