[Pdbg] [PATCH v2 2/2] pdbg: Remove default_backend() selection
Alistair Popple
alistair at popple.id.au
Wed Jul 3 11:56:14 AEST 2019
> > @@ -690,9 +593,27 @@ int main(int argc, char *argv[])
> >
> > return 1;
> >
> > }
> >
> > - /* Disable unselected targets */
> > - if (!target_selection())
> > + if (backend) {
> > + fprintf(stderr, "WARNING: Explicit backend selection
> > should no longer be required\n");
> > + fprintf(stderr, " and will be deprecated in al,
pathsel_count))
> + return false;
> > future release.\n");
> > + fprintf(stderr, " Removing -b/-d command line
> > options will remove this warning.\n");
> > + fprintf(stderr, " An explicit device-tree can
> > still be selected using the\n");
> > + fprintf(stderr, " LPDBG_DTB environment
> > variable instead.\n");
> > + pdbg_set_backend(backend, device_node);
> > + }
> > +
> > + pdbg_targets_init(NULL);
> > +
> > + if (pathsel_count) {
> > + if (!path_target_parse(pathsel, pathsel_count))
> > + return false;
> > + }
>
> This should return 1 rather than false.
Good catch, will resubmit with the fix.
- Alistair
More information about the Pdbg
mailing list