[Pdbg] [PATCH 3/6] libpdbg: Fix clang warning -Wempty-body

Alistair Popple alistair at popple.id.au
Tue Jul 2 11:59:00 AEST 2019


Reviewed-by: Alistair Popple <alistair at popple.id.au>

On Wednesday, 19 June 2019 1:15:47 PM AEST Amitay Isaacs wrote:
> Signed-off-by: Amitay Isaacs <amitay at ozlabs.org>
> ---
>  libpdbg/bmcfsi.c | 3 ++-
>  1 file changed, 2 insertions(+), 1 deletion(-)
> 
> diff --git a/libpdbg/bmcfsi.c b/libpdbg/bmcfsi.c
> index 1b5d2ed..1d2e304 100644
> --- a/libpdbg/bmcfsi.c
> +++ b/libpdbg/bmcfsi.c
> @@ -160,7 +160,8 @@ static inline void clock_cycle(struct gpio_pin *pin, int
> num_clks) volatile int j;
> 
>  	/* Need to introduce delays when inlining this function */
> -	for (j = 0; j < clock_delay; j++);
> +	for (j = 0; j < clock_delay; j++)
> +		;
>          for (i = 0; i < num_clks; i++) {
>                  write_gpio(pin, 0);
>                  write_gpio(pin, 1);




More information about the Pdbg mailing list