[Pdbg] [PATCH 1/2] sbefifo: Improve the log output, drop extra newline

Alistair Popple alistair at popple.id.au
Fri Aug 2 13:51:03 AEST 2019


Reviewed-by: Alistair Popple <alistair at popple.id.au>

On Friday, 2 August 2019 12:26:42 PM AEST Amitay Isaacs wrote:
> Signed-off-by: Amitay Isaacs <amitay at ozlabs.org>
> ---
>  libpdbg/sbefifo.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/libpdbg/sbefifo.c b/libpdbg/sbefifo.c
> index c251089..90cf83e 100644
> --- a/libpdbg/sbefifo.c
> +++ b/libpdbg/sbefifo.c
> @@ -386,7 +386,7 @@ static int sbefifo_op_control(struct sbefifo *sbefifo,
>  	uint32_t cmd, op, out_len, status;
>  	int rc;
>  
> -	PR_NOTICE("sbefifo: control c:0x%x, t=%u\n, op=%u\n", core_id, thread_id, oper);
> +	PR_NOTICE("sbefifo: control c:0x%x, t=0x%x, op=%u\n", core_id, thread_id, oper);
>  
>  	op = ((core_id & 0xff) << 8) | ((thread_id & 0x0f) << 4) | (oper & 0x0f);
>  	cmd = SBEFIFO_CMD_CLASS_INSTRUCTION | SBEFIFO_CMD_CONTROL_INSN;
> 






More information about the Pdbg mailing list