[Pdbg] [PATCH v2 00/16] Basic gdbserver for POWER8

[Nicholas Piggin]

On Fri,  7 Sep 2018 16:39:59 +1000
Rashmica Gupta <rashmica.g at gmail.com> wrote:

> I have rebased Alistair's gdbserver on master and done a few cleanups.
> I have been using Amitay's patch "main: Add P8 kernel devicetree" when
> running on a BMC.
> 
> This should let you do basic things through gdb like examine the
> registers, read and write to kernel memory, and step through the
> kernel. There is obviously a lot more to be done, but it would be nice
> to get some of this upstream so I don't have to keep rebasing as often :)
> 
> Currently this is only designed to work on kernel addresses (as the
> translation to real addresses is trivial). Any thoughts on how we
> could/should go about dealing with address translations are welcome.
> It would be nice if we could attempt to deal with kernel virtual
> addresses and skiboot addresses.
> 
> ------
> v1->v2: A few changes as suggested by Nick (get gprs in one batch,
> a few #defines). And a couple of other tidyups like use the exisitng
> logging functions, don't segfault when given an invalid target etc,
> and an additional state in the state machine to make sure we wait for
> the thread to start before checking if we've been quiesced.

I've just gone through some of the prep patches and they're all pretty
good fixes and cleanups we should merge asap. So for patches 1-10,

Reviewed-by: Nicholas Piggin <npiggin at gmail.com>

> 
> 
> Alistair Popple (2):
>   pdbg/gdbserver: Add in basic skeleton for a gdbserver on p8
>   pdbg/gdbserver: Make ragel optional
> 
> Rashmica Gupta (14):
>   libpdbg: Release adu lock when erroring out
>   pdbg: Fix function call for putnia command
>   libpdbg: Print the name of the instruction when erroring
>   libpdbg: Remove unused error code
>   libpdbg: Check if scom controllers are exposed
>   libpdbg: Add in getxer and putxer functions
>   pdbg: Add getxer & putxer commands
>   libpdbg: Make getcr actually get all of the Condition Register
>   libpdbg: Add in mtocrf and putcr function
>   pdbg: Add getcr and putcr options
>   pdbg: Add in parser for uint16_t
>   libpdbg: Add in enable_attn function for p8
>   pdbg/gdbserver: Make gdbserver optional
>   README: Add some gdbserver info