[Pdbg] [PATCH v3 13/16] libpdbg: Add an api for address translation

[Alistair Popple]

> --- a/libpdbg/target.c
> +++ b/libpdbg/target.c
> @@ -36,6 +36,11 @@ static struct pdbg_target *get_class_target_addr(struct
> pdbg_target *target, con return target;
>  }
> 
> +struct pdbg_target *pdbg_address_absolute(struct pdbg_target *target,
> uint64_t *addr) +{
> +	return get_class_target_addr(target, "pib", addr);

So this will just result in hitting the assert in get_class_target_addr() if a 
non-scommable target is passed in? That seems reasonable to me as for the 
moment as I have ideas for fixing that once this series is merged so:

Reviewed-by: Alistair Popple <alistair at popple.id.au>

> +}
> +
>  /* The indirect access code was largely stolen from hw/xscom.c in skiboot
> */ #define PIB_IND_MAX_RETRIES 10
>  #define PIB_IND_READ PPC_BIT(0)