[Pdbg] [PATCH v2 05/15] main: Add an option for path based targetting

Alistair Popple alistair at popple.id.au
Tue Nov 13 13:50:35 AEDT 2018


> +		case 'P':
> +			if (!pathsel_add("%s", optarg))

That makes more sense to me at least :-)

As I think we have discussed it would be ideal to have the paths after the 
commands but that will be easier to do once we have this series merged. 
Thanks!

Reviewed-by: Alistair Popple <alistair at popple.id.au>

> +				opt_error = true;
> +			break;
> +
>  		case 'S':
>  			progress_shutup();
>  			break;
> @@ -650,6 +693,11 @@ static bool target_selection(void)
>  			target_unselect(fsi);
>  	}
> 
> +	if (pathsel_count) {
> +		if (!path_target_parse(pathsel, pathsel_count))
> +			return false;
> +	}
> +
>  	return true;
>  }




More information about the Pdbg mailing list