[Pdbg] [PATCH v2 01/15] libpdbg: Convert printf to DEBUG statements
Alistair Popple
alistair at popple.id.au
Tue Nov 13 12:58:53 AEDT 2018
Reviewed-by: Alistair Popple <alistair at popple.id.au>
On Friday, 9 November 2018 6:09:57 PM AEDT Amitay Isaacs wrote:
> Signed-off-by: Amitay Isaacs <amitay at ozlabs.org>
> ---
> libpdbg/fake.c | 12 +++++++-----
> 1 file changed, 7 insertions(+), 5 deletions(-)
>
> diff --git a/libpdbg/fake.c b/libpdbg/fake.c
> index 58e7e18..a816ff5 100644
> --- a/libpdbg/fake.c
> +++ b/libpdbg/fake.c
> @@ -13,20 +13,22 @@
> * see the license for the specific language governing permissions and
> * limitations under the license.
> */
> -#include "operations.h"
> #include <stdio.h>
> #include <inttypes.h>
>
> +#include "libpdbg.h"
> +#include "operations.h"
> +
> static int fake_fsi_read(struct fsi *fsi, uint32_t addr, uint32_t *value)
> {
> *value = 0xfeed0cfa;
> - printf("fake_fsi_read(0x%04" PRIx32 ", 0x%04" PRIx32 ")\n", addr,
*value);
> + PR_DEBUG("fake_fsi_read(0x%04" PRIx32 ", 0x%04" PRIx32 ")\n", addr,
> *value); return 0;
> }
>
> static int fake_fsi_write(struct fsi *fsi, uint32_t addr, uint32_t value)
> {
> - printf("fake_fsi_write(0x%04" PRIx32 ", 0x%04" PRIx32 ")\n", addr,
value);
> + PR_DEBUG("fake_fsi_write(0x%04" PRIx32 ", 0x%04" PRIx32 ")\n", addr,
> value); return 0;
> }
>
> @@ -44,13 +46,13 @@ DECLARE_HW_UNIT(fake_fsi);
> static int fake_pib_read(struct pib *pib, uint64_t addr, uint64_t *value)
> {
> *value = 0xdeadbeef;
> - printf("fake_pib_read(0x%08" PRIx64 ", 0x%08" PRIx64 ")\n", addr,
*value);
> + PR_DEBUG("fake_pib_read(0x%08" PRIx64 ", 0x%08" PRIx64 ")\n", addr,
> *value); return 0;
> }
>
> static int fake_pib_write(struct pib *pib, uint64_t addr, uint64_t value)
> {
> - printf("fake_pib_write(0x%08" PRIx64 ", 0x%08" PRIx64 ")\n", addr,
value);
> + PR_DEBUG("fake_pib_write(0x%08" PRIx64 ", 0x%08" PRIx64 ")\n", addr,
> value); return 0;
> }
More information about the Pdbg
mailing list