[Pdbg] [PATCH v2 01/16] libpdbg: Add api to get 32-bit device tree property

[Amitay Isaacs]

On Wed, 2018-11-07 at 16:39 +1100, Alistair Popple wrote:
> ---
>  libpdbg/libpdbg.c | 12 ++++++++++++
>  libpdbg/libpdbg.h |  1 +
>  2 files changed, 13 insertions(+)
> 
> diff --git a/libpdbg/libpdbg.c b/libpdbg/libpdbg.c
> index 810e045..ccaad3e 100644
> --- a/libpdbg/libpdbg.c
> +++ b/libpdbg/libpdbg.c
> @@ -186,6 +186,18 @@ static int pdbg_get_target_u64_property(struct
> pdbg_target *target, const char *
>  	return 0;
>  }
>  
> +int pdbg_get_target_u32_property(struct pdbg_target *target, const
> char *name, uint32_t *val)
> +{
> +	struct dt_property *p;
> +
> +	p = dt_find_property(target, name);
> +	if (!p)
> +		return -1;
> +
> +	*val = dt_get_number(p->prop, 1);
> +	return 0;
> +}
> +

Shouldn't this check if the property value is actually defined as u32?
Currently it just gets the first 32 bits as stored in the fdt.


>  int pdbg_get_u64_property(struct pdbg_target *target, const char
> *name, uint64_t *val)
>  {
>  	struct pdbg_target *dn;
> diff --git a/libpdbg/libpdbg.h b/libpdbg/libpdbg.h
> index 1977c75..138521c 100644
> --- a/libpdbg/libpdbg.h
> +++ b/libpdbg/libpdbg.h
> @@ -72,6 +72,7 @@ void pdbg_set_target_property(struct pdbg_target
> *target, const char *name, cons
>  
>  /* Get the given property and return the size */
>  void *pdbg_get_target_property(struct pdbg_target *target, const
> char *name, size_t *size);
> +int pdbg_get_target_u32_property(struct pdbg_target *target, const
> char *name, uint32_t *val);
>  int pdbg_get_u64_property(struct pdbg_target *target, const char
> *name, uint64_t *val);
>  uint64_t pdbg_get_address(struct pdbg_target *target, uint64_t
> *size);
>  
> -- 
> 2.11.0
> 

Amitay.
-- 

No one can make you feel inferior without your consent. - Eleanor Roosvelt