[Pdbg] [PATCH 05/10] pdbg: Tidy up putnia/putmsr

Rashmica Gupta rashmica.g at gmail.com
Thu May 31 15:29:10 AEST 2018


The number of arguments required for these functions is wrong -
it requires 2 arguments for putnia and putmsr, and the second one
is written. The code has obviously been copy/pasted from getgpr/getspr
functions where you need to supply which register and then the data.

Signed-off-by: Rashmica Gupta <rashmica.g at gmail.com>
---
 src/reg.c | 8 ++++----
 1 file changed, 4 insertions(+), 4 deletions(-)

diff --git a/src/reg.c b/src/reg.c
index 416236b..e252ab8 100644
--- a/src/reg.c
+++ b/src/reg.c
@@ -152,13 +152,13 @@ int handle_nia(int optind, int argc, char *argv[])
 	if (strcmp(argv[optind], "putnia") == 0) {
 		uint64_t data;
 
-		if (optind + 2 >= argc) {
+		if (optind + 1 >= argc) {
 			printf("%s: command '%s' requires data\n", argv[0], argv[optind]);
 			return -1;
 		}
 
 		errno = 0;
-		data = strtoull(argv[optind + 2], &endptr, 0);
+		data = strtoull(argv[optind + 1], &endptr, 0);
 		if (errno || *endptr != '\0') {
 			printf("%s: command '%s' couldn't parse data '%s'\n",
 				argv[0], argv[optind], argv[optind + 1]);
@@ -221,13 +221,13 @@ int handle_msr(int optind, int argc, char *argv[])
 	if (strcmp(argv[optind], "putmsr") == 0) {
 		uint64_t data;
 
-		if (optind + 2 >= argc) {
+		if (optind + 1 >= argc) {
 			printf("%s: command '%s' requires data\n", argv[0], argv[optind]);
 			return -1;
 		}
 
 		errno = 0;
-		data = strtoull(argv[optind + 2], &endptr, 0);
+		data = strtoull(argv[optind + 1], &endptr, 0);
 		if (errno || *endptr != '\0') {
 			printf("%s: command '%s' couldn't parse data '%s'\n",
 				argv[0], argv[optind], argv[optind + 1]);
-- 
2.14.3



More information about the Pdbg mailing list