[Pdbg] [PATCH] Revert "Makefile: Don't suppress warnings from DTC"

Amitay Isaacs amitay at ozlabs.org
Fri May 25 14:06:46 AEST 2018


On Fri, 2018-05-25 at 13:23 +0930, Joel Stanley wrote:
> This reverts commit dc35dbc74cd930778d04186fd35aebb827c56e8a.
> 
> There appears to still be a number of warnings from the dtc step.
> This
> may depend on the configuration of the system, so suppress the
> warnings
> until we have those issues worked out.

The errors are not related to the system configuration, but purely bugs
in the generated dts.  Let's fix the problem and not get rid of
symptom. :-)

I have a patch coming with some more fixes to device trees.

> 
> Signed-off-by: Joel Stanley <joel at jms.id.au>
> ---
> I am using 1.4.5 on Ubuntu 18.04.
> 
>  Makefile.am | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/Makefile.am b/Makefile.am
> index a5e89c4e26bc..3dd62cf1e1b7 100644
> --- a/Makefile.am
> +++ b/Makefile.am
> @@ -83,7 +83,7 @@ GEN_V_ = $(GEN_V_$(AM_DEFAULT_VERBOSITY))
>  GEN_V_0 = @echo "  GEN     " $@;
>  
>  %.dts: %.dts.m4
> -	$(M4_V)$(M4) -I$(dir $<) $< | $(DTC) -I dts -O dts > $@
> +	$(M4_V)$(M4) -I$(dir $<) $< | $(DTC) -q -I dts -O dts > $@
>  
>  %.dtsi: %.dtsi.m4
>  	$(M4_V)$(M4) -I$(dir $<) $< > $@
> @@ -93,7 +93,7 @@ p9r-fsi.dts: p9r-fsi.dts.m4 p9-fsi.dtsi
>  p9z-fsi.dts: p9z-fsi.dts.m4 p9-fsi.dtsi
>  
>  %.dtb: %.dts
> -	$(DTC_V)$(DTC) -i$(dir $@) -I dts $< -O dtb > $@
> +	$(DTC_V)$(DTC) -q -i$(dir $@) -I dts $< -O dtb > $@
>  
>  %.dt.h: %.dtb
>  	$(GEN_V)$(srcdir)/generate_dt_header.sh $< > $@
> -- 
> 2.17.0
> 

Amitay.
-- 

Life in the real world is far more interesting, far more important, far
richer, than anything you'll ever find on a computer screen.  - Clifford Stoll


More information about the Pdbg mailing list