[Pdbg] [PATCH 3/3] libpdbg: Wrappers for cache inhibited adu_getmem and adu_putmem

Alistair Popple alistair at popple.id.au
Thu May 24 22:36:22 AEST 2018


> > Do you think we should maintain these as a user callable library API? Or should
> > we just remove it and refactor the existing code to use the _ci versions
> > instead?
> 
> I refactored them out, but then the getmem command has to do if (ci)
> adu_getmem_ci() else adu_getmem(), so I made them public again.
> 
> I don't have any strong opinions. If you think we should hide them
> then I'm happy to rework to do that.

Thanks Joel. I tried reworking them to remove the _ci versions but it just made
the application code more complicated/less readable so I've merged this series
as is.

- Alistair

> Cheers,
> 
> Joel
> 




More information about the Pdbg mailing list