[Pdbg] [PATCH v2 4/9] dt: Add missing #address-cells, #size-cells and reg properties

Amitay Isaacs amitay at ozlabs.org
Wed May 23 14:31:05 AEST 2018


Signed-off-by: Amitay Isaacs <amitay at ozlabs.org>
---
 p8-fsi.dts.m4    | 2 ++
 p8-host.dts.m4   | 2 ++
 p8-i2c.dts.m4    | 2 ++
 p9-host.dts.m4   | 6 ++++++
 p9-kernel.dts.m4 | 6 ++++++
 p9-pib.dts.m4    | 4 ++--
 6 files changed, 20 insertions(+), 2 deletions(-)

diff --git a/p8-fsi.dts.m4 b/p8-fsi.dts.m4
index 7b004ac..12751c5 100644
--- a/p8-fsi.dts.m4
+++ b/p8-fsi.dts.m4
@@ -31,6 +31,8 @@
 		};
 
 		hmfsi at 100000 {
+			#address-cells = <0x2>;
+			#size-cells = <0x1>;
 			compatible = "ibm,fsi-hmfsi";
 			reg = <0x0 0x100000 0x8000>;
 			port = <0x1>;
diff --git a/p8-host.dts.m4 b/p8-host.dts.m4
index 3197da7..ed88a55 100644
--- a/p8-host.dts.m4
+++ b/p8-host.dts.m4
@@ -9,6 +9,7 @@
 	      #address-cells = <0x2>;
 	      #size-cells = <0x1>;
 	      compatible = "ibm,host-pib";
+	      reg = <0x0>;
 	      chip-id = <0x0>;
 	      index = <0x0>;
 	      include(p8-pib.dts.m4)dnl
@@ -18,6 +19,7 @@
 	      #address-cells = <0x2>;
 	      #size-cells = <0x1>;
 	      compatible = "ibm,host-pib";
+	      reg = <0x8>;
 	      chip-id = <0x8>;
 	      index = <0x1>;
 	      include(p8-pib.dts.m4)dnl
diff --git a/p8-i2c.dts.m4 b/p8-i2c.dts.m4
index 1e794bf..53f2ace 100644
--- a/p8-i2c.dts.m4
+++ b/p8-i2c.dts.m4
@@ -22,6 +22,8 @@
 			compatible = "ibm,power8-opb";
 
 			hmfsi at 100000 {
+				#address-cells = <0x2>;
+				#size-cells = <0x1>;
 				compatible = "ibm,power8-opb-hmfsi";
 				reg = <0x100000 0x80000>;
 				port = <0x1>;
diff --git a/p9-host.dts.m4 b/p9-host.dts.m4
index 5566acd..e1ec779 100644
--- a/p9-host.dts.m4
+++ b/p9-host.dts.m4
@@ -6,14 +6,20 @@
 
 	/* Host based debugfs access */
 	pib at 0 {
+	      #address-cells = <0x2>;
+	      #size-cells = <0x1>;
 	      compatible = "ibm,host-pib";
+	      reg = <0x0>;
 	      chip-id = <0x0>;
 	      index = <0x0>;
 	      include(p9-pib.dts.m4)dnl
 	};
 
 	pib at 8 {
+	      #address-cells = <0x2>;
+	      #size-cells = <0x1>;
 	      compatible = "ibm,host-pib";
+	      reg = <0x8>;
 	      chip-id = <0x8>;
 	      index = <0x1>;
 	      include(p9-pib.dts.m4)dnl
diff --git a/p9-kernel.dts.m4 b/p9-kernel.dts.m4
index e364214..195be59 100644
--- a/p9-kernel.dts.m4
+++ b/p9-kernel.dts.m4
@@ -14,6 +14,8 @@
 		status = "mustexist";
 
 		pib at 1000 {
+			#address-cells = <0x2>;
+			#size-cells = <0x1>;
 			reg = <0x0 0x1000 0x7>;
 			index = <0x0>;
 			compatible = "ibm,fsi-pib", "ibm,power9-fsi-pib";
@@ -21,12 +23,16 @@
 		};
 
 		hmfsi at 100000 {
+			#address-cells = <0x2>;
+			#size-cells = <0x1>;
 			compatible = "ibm,fsi-hmfsi";
 			reg = <0x0 0x100000 0x8000>;
 			port = <0x1>;
 			index = <0x1>;
 
 			pib at 1000 {
+				#address-cells = <0x2>;
+				#size-cells = <0x1>;
 				 reg = <0x0 0x1000 0x7>;
 				 index = <0x1>;
 				 compatible = "ibm,fsi-pib", "ibm,power9-fsi-pib";
diff --git a/p9-pib.dts.m4 b/p9-pib.dts.m4
index e0248d1..3e312e5 100644
--- a/p9-pib.dts.m4
+++ b/p9-pib.dts.m4
@@ -2,6 +2,8 @@ define(`CONCAT', `$1$2')dnl
 define(`HEX', `CONCAT(0x, $1)')dnl
 define(`CORE_BASE', `eval(0x20000000 + $1 * 0x1000000, 16)')dnl
 define(`CORE', `chiplet at CORE_BASE($1) {
+#address-cells = <0x2>;
+#size-cells = <0x1>;
 compatible = "ibm,power9-chiplet";
 index = <HEX(eval($2, 16))>;
 reg = <0x0 HEX(CORE_BASE($1)) 0xfffff>;
@@ -33,8 +35,6 @@ index = <HEX(eval($1, 16))>;
 reg = <0x0 HEX(CHIPLET_BASE($1)) 0xfffff>;
 }')dnl
 
-#address-cells = <0x2>;
-#size-cells = <0x1>;
 
 adu at 90000 {
 	  compatible = "ibm,power9-adu";
-- 
2.17.0



More information about the Pdbg mailing list